Request a Demo
Home   >   mailing lists

Re: pgsql: Remove unneeded defines from pg_config.h.in - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove unneeded defines from pg_config.h.in
Date
Msg-id 1193764.1767573683@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Remove unneeded defines from pg_config.h.in  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Remove unneeded defines from pg_config.h.in
List pgsql-committers
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.

This patch is not okay.  pg_config.h.in is a generated file and
hand modifications in it will not do.

If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.

            regards, tom lane

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Remove unneeded defines from pg_config.h.in
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in