Re: query_id: jumble names of temp tables for better pg_stat_statement UX - Mailing list pgsql-hackers

From Tom Lane
Subject Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date
Msg-id 1192185.1742871390@sss.pgh.pa.us
Whole thread Raw
In response to Re: query_id: jumble names of temp tables for better pg_stat_statement UX  (Sami Imseih <samimseih@gmail.com>)
Responses Re: query_id: jumble names of temp tables for better pg_stat_statement UX
List pgsql-hackers
Sami Imseih <samimseih@gmail.com> writes:
> I agree that some may want stats to merge for the same tables,
> and others may not. I will suggest this with some hesitation, but why not
> make this behavior configurable via a GUC?
> We recently introduced query_id_squash_values for controlling
> the merge of an IN list, maybe this is another queryId behavior we should
> provide a configuration for?

I don't like that GUC and I would not like this one either.  We
learned years ago that GUCs that change query semantics are a bad
idea, but apparently now we have hackers who need to relearn that
lesson the hard way.  (Admittedly, this isn't quite *query* semantics,
which perhaps lessens the blast radius.  But I think we're still going
to regret query_id_squash_values.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: AIO v2.5
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: pgoutput: comment atop rel_sync_cache_publication_cb() has an inconsistency