Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space
Date
Msg-id 11911.1447857045@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space  (Bruce Momjian <bruce@momjian.us>)
List pgsql-bugs
Bruce Momjian <bruce@momjian.us> writes:
> Very good points.  The attached patch fixes the copy parameter and
> addresses the errno issue by just using errno direcdtly after the
> _dosmaperr call.

You did not change the comment

   *    Returns the text of the error message for the given error number

even though no error number is a "given" parameter anymore.  Maybe
"... for the most-recently-reported error"?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space
Next
From: Bruce Momjian
Date:
Subject: Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space