Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query
Date
Msg-id 11886611530520937@web27g.yandex.ru
Whole thread Raw
In response to Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
Hello

I found SELECT pg_stat_statements_reset(NULL,NULL,s.queryid) in tests and it pass tests, but i wonder how it works.
Shouldnot we check the NULL through PG_ARGISNULL macro before any PG_GETARG_*? According src/include/fmgr.h 
 
> * If function is not marked "proisstrict" in pg_proc, it must check for
> * null arguments using this macro.  Do not try to GETARG a null argument!

> pg_stat_statements_reset(userid Oid, dbid Oid, queryid bigint) returns void
And you forgot to change return type in docs (and description of return value)

regards, Sergei


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: branches_of_interest.txt
Next
From: Peter Eisentraut
Date:
Subject: Re: Should contrib modules install .h files?