Re: Preserve attstattarget on REINDEX CONCURRENTLY - Mailing list pgsql-hackers

From Ronan Dunklau
Subject Re: Preserve attstattarget on REINDEX CONCURRENTLY
Date
Msg-id 11797662.T7Z3S40VBb@laptop-ronand
Whole thread Raw
In response to Preserve attstattarget on REINDEX CONCURRENTLY  (Ronan Dunklau <ronan@dunklau.fr>)
List pgsql-hackers
Le vendredi 5 février 2021, 03:17:48 CET Michael Paquier a écrit :
> ConstructTupleDescriptor() does not matter much, but this patch is not
> acceptable to me as it touches the area of the index creation while
> statistics on an index expression can only be changed with a special
> flavor of ALTER INDEX with column numbers.  This would imply an ABI
> breakage, so it cannot be backpatched as-is.

I'm not surprised by this answer, the good news is it's being back-patched.

>
> Let's copy this data in index_concurrently_swap() instead.  The
> attached patch does that, and adds a test cheaper than what was
> proposed.  There is a minor release planned for next week, so I may be
> better to wait after that so as we have enough time to agree on a
> solution.

Looks good to me ! Thank you.

--
Ronan Dunklau





pgsql-hackers by date:

Previous
From: "osumi.takamichi@fujitsu.com"
Date:
Subject: RE: Single transaction in the tablesync worker?
Next
From: Kasahara Tatsuhito
Date:
Subject: There doesn't seem to be any case where PQputCopyEnd() returns 0