Re: Implemented current_query - Mailing list pgsql-patches

From Neil Conway
Subject Re: Implemented current_query
Date
Msg-id 1178576719.6034.9.camel@goldbach
Whole thread Raw
In response to Implemented current_query  (Tomas Doran <bobtfish@bobtfish.net>)
Responses Re: Implemented current_query  (Tomas Doran <bobtfish@bobtfish.net>)
List pgsql-patches
On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote:
> As suggested in the TODO list (and as I need the functionality
> myself), I have implemented the current_query interface to
> debug_query_string.

Comments:

* docs need a bit more detail (they should emphasize that it is the
current query string submitted by the client, as opposed to the
currently executing SPI command or the like). Also, the docs currently
claim current_query() returns "name".

* use textin() to convert C-style strings to text, rather than
constructing a text datum by hand

* perhaps we can get away with marking current_query() stable?

* AFAIK debug_query_string() still does the wrong thing when the user
submits multiple queries in a single protocol message (separated by
semi-colons). Not sure there's a way to fix that that is both easy and
efficient, though...

-Neil



pgsql-patches by date:

Previous
From: "William Lawrance"
Date:
Subject: ECPG patch to use prepare for improved performance
Next
From: Zoltan Boszormenyi
Date:
Subject: Re: [HACKERS] Behavior of GENERATED columns per SQL2003