Re: [HACKERS] Patch to log usage of temporary files - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Patch to log usage of temporary files
Date
Msg-id 11783.1168381478@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Patch to log usage of temporary files  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [HACKERS] Patch to log usage of temporary files  (Bruce Momjian <bruce@momjian.us>)
Re: [HACKERS] Patch to log usage of temporary files  (Bill Moran <wmoran@collaborativefusion.com>)
List pgsql-patches
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Surely the measurement unit should be kbytes or disk blocks.  And why
>> aren't you using that GUC UNITS infrastructure Peter put in?

> Agreed.  I have applied the following patch to make it kilobytes, and
> documented it.  I didn't put '-1kB' in the postgresql.conf file because
> the -1 value is special.  (ideas?)

Hmm, that could be a little bit ugly.  Suggestion: redefine the value
such that files *greater than* the given size are logged, and then zero
can be the "off" position, and we need not worry about whether -1 is
-1 byte or -1 kbyte.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Update UTF-8 RFC reference
Next
From: Tom Lane
Date:
Subject: Re: Last infomask bit