Re: unite recovery.conf and postgresql.conf - Mailing list pgsql-hackers

From Joshua Berkus
Subject Re: unite recovery.conf and postgresql.conf
Date
Msg-id 1178268890.215818.1316200973038.JavaMail.root@mail-1.01.com
Whole thread Raw
In response to Re: unite recovery.conf and postgresql.conf  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: unite recovery.conf and postgresql.conf
Re: unite recovery.conf and postgresql.conf
List pgsql-hackers
> I'm in favor of defining a separate, content-free trigger file to
> enable
> archive recovery.  Not sure about the name "recovery.ready", though
> ---
> that makes it look like one of the WAL archive transfer trigger
> files,
> which does not seem like a great analogy.  The pg_standby
> documentation
> suggests names like "foo.trigger" for failover triggers, which is a
> bit
> better analogy because something external to the database creates the
> file.  What about "recovery.trigger"?

Do we want a trigger file to enable recovery, or one to *disable* recovery?  Or both?

Also, I might point out that we're really confusing our users by talking about "recovery" all the time, if they're just
usingstreaming replication.  Just sayin'
 

> * will seeing these values present in pg_settings confuse anybody?

No.  pg_settings already has a couple dozen "developer" parameters which nobody not on this mailing list understands.
Addingthe recovery parameters to it wouldn't confuse anyone further, and would have the advantage of making the
recoveryparameters available by monitoring query on a hot standby.
 

For that matter, I'd suggest that we add a read-only setting called in_recovery.

> * can the values be changed when not in recovery, if so what happens,
>   and again will that confuse anybody?

Yes, and no.

> * is there any security hazard from ordinary users being able to see
>   what settings had been used?

primary_conninfo could be a problem, since it's possible to set a password there.

--Josh


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: SSI heap_insert and page-level predicate locks
Next
From: Tom Lane
Date:
Subject: Re: force_not_null option support for file_fdw