Andrew Dunstan <andrew@dunslane.net> writes:
> On 2026-09-22 Tu 3:10 AM, Peter Eisentraut wrote:
>> One surprise from this is that this generates a massive pgindent diff
>> against the current tree, because there are a bunch of entries missing
>> or wrong in src/tools/pgindent/exclude_file_patterns. I guess most
>> people don't see this because these are mostly generated files, which
>> would get reindented but then ignored via gitignore, but if you run
>> pgindent --check --diff, then this will show up.
> [koel] just runs:
> src/tools/pgindent/pgindent --diff --check .
> Of course, that's against a pure source tree.
Yeah, I generally run pgindent against a clean tree as well. We have
made some efforts to make generated files be pgindent-clean, but
it's been pretty haphazard, and I doubt we want to make a project
policy requiring that. So really the right thing is to make this
CI module do likewise.
regards, tom lane
