Re: [PATCHES] COMMIT NOWAIT Performance Option (patch) - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [PATCHES] COMMIT NOWAIT Performance Option (patch)
Date
Msg-id 1172533773.3760.450.camel@silverbirch.site
Whole thread Raw
Responses Re: [PATCHES] COMMIT NOWAIT Performance Option (patch)
List pgsql-hackers
On Mon, 2007-02-26 at 18:14 -0500, Tom Lane wrote:
> "Simon Riggs" <simon@2ndquadrant.com> writes:
> > A prototype patch is posted to -patches, which is WORK IN PROGRESS.
> > [This patch matches discussion thread on -hackers.]
>
> What does this accomplish other than adding syntactic sugar over a
> feature that really doesn't work well anyway?  I don't see any point
> in encouraging people to use commit_delay in its present form.  If we
> had a portable solution for millisecond-or-so waits then maybe it would
> work ...

This patch doesn't intend to implement group commit. I've changed the
meaning of commit_delay, sorry if that confuses.

You and I discussed this in Toronto actually, IIRC. The best way to
describe this proposal is deferred fsync, so perhaps a different
parameter commit_fsync_delay would be more appropriate.

Bruce has requested this feature many times from me, so I thought it
about time to publish.

The key point is that COMMIT NOWAIT doesn't wait for group commit to
return, it just doesn't wait at all - leaving someone else to flush WAL.
It's much better than fsync=off.

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Seeking Google SoC Mentors
Next
From: "Simon Riggs"
Date:
Subject: Re: COMMIT NOWAIT Performance Option