Re: [PATCHES] wal_checksum = on (default) | off - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [PATCHES] wal_checksum = on (default) | off
Date
Msg-id 1168527292.3951.545.camel@silverbirch.site
Whole thread Raw
In response to Re: [PATCHES] wal_checksum = on (default) | off  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, 2007-01-11 at 09:01 -0500, Tom Lane wrote:
> "Simon Riggs" <simon@2ndquadrant.com> writes:
> > COPY        XLogInsert() #1 on oprofile results at 17% CPU
> >         (full_page_writes = on)
>
> But what portion of that is actually CRC-related?  XLogInsert does quite
> a lot.
>
> Anyway, I can't see degrading the reliability of the system for a gain
> in the range of a few percent, which is the most that we'd be likely
> to get here ... for a factor of two or more, maybe people would be
> willing to take a risk.

All I would add is that the loss of reliability was not certain in all
cases, otherwise I myself would have dropped the idea long ago. With the
spectre of doubt surrounding this, I'm happy to drop the idea until we
have proof/greater certainty either way.

Patch revoked.

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: contrib/xml2 and xml type
Next
From: Gregory Stark
Date:
Subject: Re: [PATCHES] wal_checksum = on (default) | off