Re: Corner case in xlog stuff: what happens exactly at a - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Corner case in xlog stuff: what happens exactly at a
Date
Msg-id 1154964971.2570.85.camel@localhost.localdomain
Whole thread Raw
In response to Re: Corner case in xlog stuff: what happens exactly at a seg boundary?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Corner case in xlog stuff: what happens exactly at a seg boundary?
List pgsql-hackers
On Sat, 2006-08-05 at 23:59 -0400, Tom Lane wrote:
> I wrote:
> > Rather than expecting user-level scripts to get this corner case
> > right, I suggest that we ought to modify pg_stop_backup and friends
> > so that what they return is the last used byte address of WAL, not
> > the first unused byte address as now.  Then, blindly extracting
> > the filename will give the right answer about which file to archive,
> > even in the boundary case.
> 
> After further thought I desisted from that plan: changing the result
> convention of existing functions like pg_stop_backup() will break any
> existing archiving scripts that do get it right.  Instead, we can put
> the boundary-case logic into the new functions that extract a filename
> from the WAL location string that the action functions return.

This is done right? Ping me back if there's anything more to add.

--  Simon Riggs EnterpriseDB          http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Simplifying "standby mode"
Next
From: Tom Lane
Date:
Subject: Re: Simplifying "standby mode"