Re: Getting rid of extra gettimeofday() calls - Mailing list pgsql-hackers

From Hannu Krosing
Subject Re: Getting rid of extra gettimeofday() calls
Date
Msg-id 1150751798.5582.3.camel@localhost.localdomain
Whole thread Raw
In response to Getting rid of extra gettimeofday() calls  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Ühel kenal päeval, E, 2006-06-19 kell 11:17, kirjutas Tom Lane:
> As of CVS tip, PG does up to four separate gettimeofday() calls upon the
> arrival of a new client command.  This is because the statement_timestamp,
> stats_command_string, log_duration, and statement_timeout features each
> independently save an indication of statement start time.  Given what
> we've found out recently about gettimeofday() being unduly expensive on
> some hardware, this cries out to get fixed.  I propose that we do
> SetCurrentStatementStartTimestamp() immediately upon receiving a client
> message, and then make the other features copy that value instead of
> fetching their own.
> 
> Another gettimeofday() call that I would like to get rid of is the one
> currently done at the end of statement when stats_command_string is
> enabled: we record current time when resetting the activity_string to
> <IDLE>. 

Is it just <IDLE> or also <IDLE in transaction> ?

If we are going to change things anyway, I'd like the latter to show the
time since start of transaction, so that I Would at least have an easy
way to write a transaction timeout script :)


I don't really care about what plain <IDLE> uses.

-- 
----------------
Hannu Krosing
Database Architect
Skype Technologies OÜ
Akadeemia tee 21 F, Tallinn, 12618, Estonia

Skype me:  callto:hkrosing
Get Skype for free:  http://www.skype.com




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: I was offline
Next
From: Theo Schlossnagle
Date:
Subject: Re: Generic Monitoring Framework Proposal