Re: [PATCHES] Patch to fix plpython on OS X - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCHES] Patch to fix plpython on OS X
Date
Msg-id 1150.24.211.165.134.1122212442.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: [PATCHES] Patch to fix plpython on OS X  (Michael Fuhr <mike@fuhr.org>)
Responses Re: [PATCHES] Patch to fix plpython on OS X
List pgsql-hackers
Michael Fuhr said:

> I just built Python 2.3 and it does indeed format the error differently
> than later versions (the format appears to have changed in 2.3.1):
>
[snip]
> I've attached two new files that should go in the plpython directory:
>
> resultmap
> expected/plpython_error_py23.out
>
> A problem with this patch is that it assumes a version of Python
> based on the OS, which might clean up the current buildfarm but
> that isn't really correct.  Is there a better way to handle this?


This is completely unnecessary - pg_regress has an alternative result
mechanism that doesn't rely on a resultmap file. Just name your alternative
result file foo_n.out instead of foo.out, for some n in [0-9]. In this case,
call it, say, plpython_error_1.out. Job done, and no OS dependence.

cheers

andrew



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: interval->day patch and docs
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Patch to fix plpython on OS X