Re: pgindent && weirdness - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent && weirdness
Date
Msg-id 11491.1589581114@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent && weirdness  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-May-16, Thomas Munro wrote:
>> Here's the patch I propose to commit to pg_bsd_indent, if the repo
>> lets me, and here's the result of running it on the PG tree today.

> Looks good.  Of all these changes in PG, only two are of the STACK_OK()
> nature, and there are 38 places that get better.

It should also be noted that there are a lot of places where we've
programmed around this silliness by artificially breaking conditions
using IsA() into multiple lines.  So the "38 places" is a lowball
estimate of how much of a problem this has been.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgindent && weirdness
Next
From: Ranier Vilela
Date:
Subject: Re: calling procedures is slow and consumes extra much memory againstcalling function