Re: pgsql: Allow pg_resetxlog -f to reset pg_control - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Allow pg_resetxlog -f to reset pg_control
Date
Msg-id 1146074464.3120.32.camel@localhost.localdomain
Whole thread Raw
In response to pgsql: Allow pg_resetxlog -f to reset pg_control counters using xlog  (momjian@postgresql.org (Bruce Momjian))
Responses Re: pgsql: Allow pg_resetxlog -f to reset pg_control
List pgsql-committers
It appears to me that a line like this has been missed out for when
mode==GUESS

    ControlFile.checkPointCopy.ThisTimeLineID = 2;

(search for 514...)

The old line which guessed at
    ControlFile.checkPointCopy.ThisTimeLineID = 1;
has been removed, but with nothing to replace it, except in WAL mode.

I'd prefer to guess the TLI as 2, since that is usually one more than
where we got to previously, and much more likely to be a reasonable
value choice.

On Tue, 2006-04-25 at 23:17 -0300, Bruce Momjian wrote:
> Log Message:
> -----------
> Allow pg_resetxlog -f to reset pg_control counters using xlog
> information, and add a -r option to reset pg_control without affecting
> xlog.

>     pgsql/src/bin/pg_resetxlog:
>         pg_resetxlog.c (r1.43 -> r1.44)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_resetxlog/pg_resetxlog.c.diff?r1=1.43&r2=1.44)
>

--
  Simon Riggs
  EnterpriseDB          http://www.enterprisedb.com/


pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Allow pg_resetxlog -f to reset pg_control counters using xlog
Next
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Enhanced containment selectivity function for /contrib/ltree