Re: WIP: splitting BLCKSZ - Mailing list pgsql-patches

From Simon Riggs
Subject Re: WIP: splitting BLCKSZ
Date
Msg-id 1144178304.13549.554.camel@localhost.localdomain
Whole thread Raw
In response to Re: WIP: splitting BLCKSZ  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: WIP: splitting BLCKSZ  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Tue, 2006-04-04 at 17:33 +0100, Simon Riggs wrote:
> On Tue, 2006-04-04 at 11:13 -0400, Tom Lane wrote:
> > Simon Riggs <simon@2ndquadrant.com> writes:
> > > I see you've changed the control file back from XLOG_BLCKSZ to BLCKSZ; I
> > > wasn't sure which one of those to choose.
> >
> > Hm.  The entire point of having a BLCKSZ-sized control file is to have
> > it *not* change in size across format revisions (see the comments) ...
> > which I suppose means that we really ought to have a hard-wired separate
> > constant, rather than depending on something that someone might want to
> > twiddle.

An additional patch enclosed that adds xlog blcksz onto the xlog long
header at the start of each xlog file, so we can cross-check between
file and system, as we do with xlog seg size.

(This is an *additional* patch, not a replacement one).

Best Regards, Simon Riggs

Attachment

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: Re: WIP: splitting BLCKSZ
Next
From: Tom Lane
Date:
Subject: Re: WIP: splitting BLCKSZ