Re: Grammer Cleanup - Mailing list pgsql-patches

From Tom Lane
Subject Re: Grammer Cleanup
Date
Msg-id 11381.1104342631@sss.pgh.pa.us
Whole thread Raw
In response to Re: Grammer Cleanup  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Grammer Cleanup  (Stephen Frost <sfrost@snowman.net>)
List pgsql-patches
Stephen Frost <sfrost@snowman.net> writes:
> Do you agree with the other changes (ColId -> SchemaName, ColId ->=20
> SavePointId) ?

I don't really see the value of them.  They add some marginal
documentation I suppose, but they also make the grammar bigger and
slower.  A more substantial objection to the practice is that it can
introduce needless shift/reduce conflicts, by forcing the parser into
making unnecessary decisions before it has enough context to
determine what kind of name a particular token really is.

(I don't claim that your patch as it stands has any such problem,
because it doesn't touch any particularly hairy parts of the grammar.
I'm just saying why I don't necessarily believe in a separate production
for every kind of name.)

            regards, tom lane

pgsql-patches by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Grammer Cleanup
Next
From: Stephen Frost
Date:
Subject: Re: Grammer Cleanup