Re: Uninstall scripts for contrib - Mailing list pgsql-patches

From Neil Conway
Subject Re: Uninstall scripts for contrib
Date
Msg-id 1137388391.9145.69.camel@localhost.localdomain
Whole thread Raw
In response to Uninstall scripts for contrib  (David Fetter <david@fetter.org>)
Responses Re: Uninstall scripts for contrib
List pgsql-patches
On Sun, 2006-01-15 at 20:08 -0800, David Fetter wrote:
> *** contrib/chkpass/Makefile    27 Sep 2005 17:13:00 -0000      1.7
> --- contrib/chkpass/Makefile    14 Jan 2006 23:16:03 -0000
> ***************
> *** 1,9 ****
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.6 2004/08/20
> 20:13:02 momjian Exp $
>
>   MODULE_big = chkpass
>   OBJS = chkpass.o
>   SHLIB_LINK = $(filter -lcrypt, $(LIBS))
>   DATA_built = chkpass.sql
>   DOCS = README.chkpass
>
>   ifdef USE_PGXS
> --- 1,10 ----
> ! # $PostgreSQL: pgsql/contrib/chkpass/Makefile,v 1.7 2005/09/27
> 17:13:00 tgl Exp $
>
>   MODULE_big = chkpass
>   OBJS = chkpass.o
>   SHLIB_LINK = $(filter -lcrypt, $(LIBS))
>   DATA_built = chkpass.sql
> + DATA = uninstall.sql
>   DOCS = README.chkpass
>
>   ifdef USE_PGXS

The change to $PostgreSQL$ is bogus (perhaps due to the way you setup
cvsup?), as are all the other $PostgreSQL$ changes in the patch. Also,
the patch doesn't actually add any files called "uninstall.sql".

-Neil



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: inferred param types for PREPARE
Next
From: David Fetter
Date:
Subject: Re: Uninstall scripts for contrib