Re: pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. - Mailing list pgsql-committers

Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
> Per warning from -Wmissing-format-attribute.

Hm, this is exactly what I removed yesterday, because it makes the build
fail outright on old gcc:

gcc -O1 -Wall -Wmissing-prototypes -Wpointer-arith -Wformat-security -fno-strict-aliasing -g
-I../../../src/interfaces/libpq-I../../../src/include -D_XOPEN_SOURCE_EXTENDED  -D_USE_CTYPE_MACROS  -c -o pg_dump.o
pg_dump.c
In file included from pg_backup.h:29,
                 from pg_backup_archiver.h:32,
                 from pg_dump.c:60:
dumputils.h:48: argument format specified for non-function `on_exit_msg_func'
make: *** [pg_dump.o] Error 1

Perhaps we have to refactor to avoid the use of a function variable
here.  It didn't seem particularly critical to do it like that rather
than with, say, a bool.

Or maybe we should turn off that warning.  It seems to be leaping to
conclusions about what the usage of the function variable is.

            regards, tom lane