Re: stderr & win32 admin check - Mailing list pgsql-patches

From Tom Lane
Subject Re: stderr & win32 admin check
Date
Msg-id 11321.1087247266@sss.pgh.pa.us
Whole thread Raw
In response to stderr & win32 admin check  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> * Created function write_stderr(const char *fmt, ...), used before elog
> can be used. This function will write to stderr on unix and on win32
> fconsole. It will write to the eventlog on win32 when running as a
> service.
> * Changed all (most? I think I got all) fprintf(stderr,...) to use this
> function instead. That way, we gain the ability to put all the other
> preivously-stderr-messages to the eventlog as well.

I'm not sure this is a good idea.  The remaining uses of stderr were
that way for a reason, not because someone had forgot to change them
into elog calls.  It would be a lot less invasive to just move the
privilege check as you originally intended.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: stderr & win32 admin check
Next
From: "Magnus Hagander"
Date:
Subject: Re: stderr & win32 admin check