Re: Fix C4819 warning in MSVC - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix C4819 warning in MSVC
Date
Msg-id 1131200.1635774961@sss.pgh.pa.us
Whole thread Raw
In response to Fix C4819 warning in MSVC  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Fix C4819 warning in MSVC
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> Reading 1051867.1635720347@sss.pgh.pa.us I noticed that hamerkop raise a C4819
> warning on brin_bloom.c, which is defined as:
>    "The file contains a character that cannot be represented in the current
>     code page (number).  Save the file in Unicode format to prevent data loss."
> The warning message is mostly gibberish but AFAICT the issue is that the
> headercomment includes a citation to the paper used for the hashing scheme, in
> which a footnote character has been copied from the paper (without the footnote
> copied).  Since the footnote is irrelevant for our documentation, I propose to
> remove this offending character to remove warnings from the build.

+1, but there are also C4819 warnings in fe_utils/print.c.  Can we get
rid of that too?  That one's a bit more integral to the code, since
(I think) it's complaining about the comments in the unicode_style table.
But maybe we could replace those with Unicode codes + symbol names?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: remove internal support in pgcrypto?
Next
From: Fujii Masao
Date:
Subject: Re: pgbench bug candidate: negative "initial connection time"