Re: Bug in SQL/MED? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Bug in SQL/MED?
Date
Msg-id 1131.1309906086@sss.pgh.pa.us
Whole thread Raw
In response to Re: Bug in SQL/MED?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> Another possibility that just occurred to me is to call the validator
> like this:
> 
>     if (OidIsValid(fdwvalidator))
>     {
>         Datum    valarg = result;
> 
>         /* pass a null options list as an empty array */
>         if (DatumGetPointer(valarg) == NULL)
>             valarg = construct_empty_array(TEXTOID);
>         OidFunctionCall2(fdwvalidator, valarg, ObjectIdGetDatum(catalogId));
>     }

> This would avoid messing with the semantics of empty options lists
> throughout foreigncmds.c, and also avoid requiring validators to deal
> with null arguments.

Not hearing any objections, I've fixed it that way.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Bug in SQL/MED?
Next
From: Craig Ringer
Date:
Subject: Re: Crash dumps