Re: remove pg_restrict workaround - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove pg_restrict workaround
Date
Msg-id 1125196.1760536713@sss.pgh.pa.us
Whole thread Raw
In response to remove pg_restrict workaround  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> When in C11 mode, MSVC supports the standard "restrict" keyword, so we 
> don't need the workaround with using "pg_restrict" instead anymore. 
> (Just for clarification, restrict is a C99 feature, but MSVC only 
> accepts it properly in C11 mode.)  So I'm proposing to remove that 
> workaround here, so that code can use the standard restrict keyword 
> without having to worry about the alternative spelling.

Won't this break extensions that are using pg_restrict?  Sure, they
could update their code, but then maybe it wouldn't work anymore
against previous branches.  Seems like it'd be better to leave
pg_restrict in place (for awhile anyway) but always #define it
as "restrict".  I don't mind ceasing to use it within our own tree
though.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Uilian Ries
Date:
Subject: Feature Request: Build only backend libraries with Meson
Next
From: Kevin K Biju
Date:
Subject: Re: Replace O_EXCL with O_TRUNC for creation of state.tmp in SaveSlotToPath