Postgres Pro
Downloads
Home   >   mailing lists

Re: compute_index_stats is missing a CHECK_FOR_INTERRUPTS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compute_index_stats is missing a CHECK_FOR_INTERRUPTS
Date
Msg-id 11242.1427582224@sss.pgh.pa.us
Whole thread Raw
In response to compute_index_stats is missing a CHECK_FOR_INTERRUPTS  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: compute_index_stats is missing a CHECK_FOR_INTERRUPTS
List pgsql-hackers
Tree view 
Jeff Janes <jeff.janes@gmail.com> writes:
> Analyze on functional indexes cannot be interrupted very easily.
> ...
> The attached patch fixes it, but don't vouch for its safety.

Hm.  The other per-sample-row loops in analyze.c use vacuum_delay_point()
rather than CHECK_FOR_INTERRUPTS() directly.  Ordinarily that wouldn't
make much difference here, but maybe a slow index function might be
incurring I/O?
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Manipulating complex types as non-contiguous structures in-memory
Next
From: Petr Jelinek
Date:
Subject: Re: Replication identifiers, take 4