Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format
Date
Msg-id 11223.1589657467@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format  (Euler Taveira <euler.taveira@2ndquadrant.com>)
Responses Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format  (Euler Taveira <euler.taveira@2ndquadrant.com>)
List pgsql-hackers
Euler Taveira <euler.taveira@2ndquadrant.com> writes:
> I'm wondering why there is such a distinction. We have some options:

> (a) leave it as is and document that those 2 options has no effect in
> pg_dump
> and possibly add a warning to report if someone uses it with an archive
> format;
> (b) exclude owner and tablespace from archive (it breaks compatibility but
> do
> exactly what users expect).

I think throwing a warning saying "this option does nothing" might be
a reasonable change.

I think (b) would be a break in the archive format, with unclear
consequences, so I'm not in favor of that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format
Next
From: Ranier Vilela
Date:
Subject: Re: Multiple FPI_FOR_HINT for the same block during killing btreeindex items