Request a Demo
Home   >   mailing lists

Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT - Mailing list pgsql-hackers

From Tom Lane
Subject Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT
Date
Msg-id 1118236.1763485279@sss.pgh.pa.us
Whole thread Raw
In response to IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
Tree view 
jian he <jian.universality@gmail.com> writes:
> [ v1-0001-IS-JSON-predicate-work-with-domain-type.patch ]

This looks like a large patch with a small patch struggling to
get out of it.  Why didn't you simply do

-    *exprtype = exprType(expr);
+    *exprtype = getBaseType(exprType(expr));

in transformJsonParseArg?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Performance issues with parallelism and LIMIT
Next
From: Bertrand Drouvot
Date:
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro