Re: A performance issue with Memoize - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A performance issue with Memoize
Date
Msg-id 1113188.1706303340@sss.pgh.pa.us
Whole thread Raw
In response to Re: A performance issue with Memoize  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: A performance issue with Memoize
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> On Sat, 27 Jan 2024 at 09:41, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> drongo and fairywren are consistently failing the test case added
>> by this commit.  I'm not quite sure why the behavior of Memoize
>> would be platform-specific when we're dealing with integers,
>> but ...

> Maybe snprintf(buf, "%.*f", 0, 5.0 / 2.0); results in "3" on those
> rather than "2"?
> Looking at the code in fmtfloat(), we fallback on the built-in snprintf.

Maybe ... I don't have a better theory.

> I can try changing the unique1 < 5 to unique1 < 4 to see that's more stable.

Worth a try.

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: A performance issue with Memoize
Next
From: Eli Schwartz
Date:
Subject: Re: make dist using git archive