Re: [PATCH] Hooks at XactCommand level - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Hooks at XactCommand level
Date
Msg-id 1112645.1627667931@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Hooks at XactCommand level  (Gilles Darold <gilles@darold.net>)
List pgsql-hackers
Gilles Darold <gilles@darold.net> writes:
> [ 00001-startcommand_xact_callback-v2.diff ]

I've not read this version of the patch, but I see from the cfbot's
results that it's broken postgres_fdw.  I recall that postgres_fdw
uses the XactCallback and SubXactCallback mechanisms, so I'm betting
this means that you've changed the semantics of those callbacks in
an incompatible way.  That's probably not a great idea.  We could
fix postgres_fdw, but there are more than likely some external
modules that would also get broken, and that is supposed to be a
reasonably stable API.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jan Wieck
Date:
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Next
From: Tomas Vondra
Date:
Subject: Re: logical decoding and replication of sequences