Re: pgsql: Fix inconsequential FILE pointer leakage - Mailing list pgsql-committers

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

--- a/src/port/exec.c
+++ b/src/port/exec.c
@@ -357,6 +357,7 @@ pipe_read_line(char *cmd, char *line, int maxsize)

    if (fgets(line, maxsize, pgver) == NULL)
    {
+       pclose(pgver);      /* no error checking */
        perror("fgets failure");
        return NULL;
    }

Doesn't this risk having pclose trash the errno setting that perror is
going to print?  If you must do this, please do it in the other order.

            regards, tom lane