Re: patch for temporary view from TODO list - Mailing list pgsql-patches

From Neil Conway
Subject Re: patch for temporary view from TODO list
Date
Msg-id 1107326223.26960.10.camel@localhost.localdomain
Whole thread Raw
In response to Re: patch for temporary view from TODO list  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote:
> isViewOnTempTable_walker.  If that isn't euphonious to you, then change
> the name of isViewOnTempTable.  Everywhere else that we have walker
> subroutines, foo() invokes foo_walker().  You need a seriously good reason
> to deviate from that convention.
[...]
> If we do have to do it this way, a minor readability improvement would
> be to write the CREATE case first and CREATE OR REPLACE second.

Patch applied to HEAD, including the above suggested changes.

Thanks for the patch, Koju.

-Neil



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: patch for temporary view from TODO list
Next
From: Heikki Linnakangas
Date:
Subject: Refactoring lock.c