Re: pg_dump - foreign table - server name is not quoted - Mailing list pgsql-bugs

From Tom Lane
Subject Re: pg_dump - foreign table - server name is not quoted
Date
Msg-id 11056.1322499118@sss.pgh.pa.us
Whole thread Raw
In response to pg_dump - foreign table - server name is not quoted  (Ronan Dunklau <rdunklau@gmail.com>)
Responses Re: pg_dump - foreign table - server name is not quoted  (Ronan Dunklau <rdunklau@gmail.com>)
List pgsql-bugs
Ronan Dunklau <rdunklau@gmail.com> writes:
> When dumping foreign tables, the server name is not properly quoted,
> which leads to unrestorable dumps.

Clearly a bug.

> Please look at the attached test case and the proposed patch.

I think this patch is not in keeping with typical coding practices in
pg_dump.  Usually we prefer to retrieve names from the server as-is,
then apply fmtId() when printing them --- this is more flexible than
having possibly-pre-quoted names in pg_dump's internal state.

Will fix it the latter way.  Thanks for the report!

            regards, tom lane

pgsql-bugs by date:

Previous
From: "Thomas Goerner"
Date:
Subject: Re: BUG #6308: Problem w. encoding in client
Next
From: Ronan Dunklau
Date:
Subject: Re: pg_dump - foreign table - server name is not quoted