Re: smallserial / serial2 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: smallserial / serial2
Date
Msg-id 1103.1308756943@sss.pgh.pa.us
Whole thread Raw
In response to Re: smallserial / serial2  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> That previous approach of adding extra expected files isn't going to
> scale nicely if there are multiple places at risk ... but do we need
> multiple places selecting the sequence contents?  I remain of the
> opinion that just omitting the value isn't good testing policy.

Actually, on looking closer, you didn't add additional selections from
sequences.  The real problem here is simply that you forgot to update
expected/sequence_1.out altogether.  So Robert's "fix" should be
reverted in favor of doing that.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Tom Lane
Date:
Subject: Re: pg_dump vs malloc