Re: Add -k/--link option to pg_combinebackup - Mailing list pgsql-hackers

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 18, 2025 at 10:31 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Just a question if everyone wants to run this. Koel takes about 10s to run the indent test.

> Well, IMHO, that's pretty cheap insurance against having to push a
> second commit to fix indentation. But I guess one problem is not
> everyone may have pgindent installed locally.

10s added to every check-world run doesn't sound "cheap" to me.
However, both pg_bsd_indent and the typedefs list are in-tree
nowadays, so I don't see any reason that this couldn't be a
totally self-contained check.

> But at least I should get it set up here. I tried setting
> PG_TEST_EXTRA=code-indent locally and running 'meson test' and I
> didn't get a failure -- and 'git grep code-indent' returned nothing.
> Any tips?

Andrew was suggesting a test we could write, not one we
already have.

            regards, tom lane