Re: unite recovery.conf and postgresql.conf - Mailing list pgsql-hackers

From Tom Lane
Subject Re: unite recovery.conf and postgresql.conf
Date
Msg-id 10986.1316097478@sss.pgh.pa.us
Whole thread Raw
In response to Re: unite recovery.conf and postgresql.conf  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: unite recovery.conf and postgresql.conf
List pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> It seems to need a bit more time until we've reached a consensus about
> the treatment of recovery.conf. How about committing the core patch
> first, and addressing the recovery.conf issue as a different patch later?

> The attached patch provides a core part of the feature, i.e., it moves
> every recovery parameters from recovery.conf to postgresql.conf.
> Even if you create recovery.conf, the server doesn't read it automatically.

> The patch renames recovery.conf to recovery.ready, so if you want to
> enter archive recovery or standby mode, you need to create
> recovery.ready file in the cluster data directory. Since recovery.ready is
> just a signal file, its contents have no effect.

This seems like it's already predetermining the outcome of the argument
about recovery.conf.  Mind you, I'm not unhappy with this choice, but
it's hardly implementing only behavior that's not being debated.

If we're satisfied with not treating recovery-only parameters different
from run-of-the-mill GUCs, this is fine.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Cédric Villemain
Date:
Subject: Re: Patch for cursor calling with named parameters
Next
From: "Andrew Dunstan"
Date:
Subject: psql setenv command