Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...)
Date
Msg-id 1096184.1782418411@sss.pgh.pa.us
Whole thread
In response to Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...)  (Sami Imseih <samimseih@gmail.com>)
List pgsql-hackers
Sami Imseih <samimseih@gmail.com> writes:
> e3a87b499 states "There's no intention to make wholesale
> changes of existing ereport calls ..."

> Why do it for pg_stat_statements only when there are a bunch
> of other places?

I think we should flat out reject this patch.  It makes no functional
improvement while creating a merge hazard for future back-patches.
That hazard might not be very large for just changing these few
spots, but any more-aggressive attempt at changing existing ereports'
style will certainly result in pain.

As e3a87b499 said, there was no plan to change existing code and
I think that decision should still stand.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alexander Nestorov
Date:
Subject: Re: [PATCH] btree_gist: add cross-type integer operator support for GiST
Next
From: Bharath Rupireddy
Date:
Subject: Re: Make pg_prewarm, autoprewarm yield for waiting DDL