Re: Hash join explain is broken - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Hash join explain is broken
Date
Msg-id 10856.1562079002@sss.pgh.pa.us
Whole thread Raw
In response to Re: Hash join explain is broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Hash join explain is broken  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Tom, any comments? Otherwise I'll go ahead, and commit after a round or
>> two of polishing.

> Sorry for not getting to this sooner --- I'll try to look tomorrow.

I took a look, and I think this is going in the right direction.
We definitely need a test case corresponding to the live bug,
and I think the comments could use more work, and there are some
cosmetic things (I wouldn't add the new struct Hash field at the
end, for instance).

            regards, tom lane



pgsql-hackers by date:

Previous
From: Rui Hai Jiang
Date:
Subject: TopoSort() fix
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Implement uuid_version()