Re: libpq ssl -> clear fallback looses error messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: libpq ssl -> clear fallback looses error messages
Date
Msg-id 1085.1223772151@sss.pgh.pa.us
Whole thread Raw
In response to Re: libpq ssl -> clear fallback looses error messages  (Magnus Hagander <magnus@hagander.net>)
Responses Re: libpq ssl -> clear fallback looses error messages
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Here's an ugly attempt towards this. Though I'm unsure if we can change
> the "const" on the PQerrorMessage parameter without messing with library
> versions and such?

That's a bad idea in any case --- PQerrorMessage shouldn't be changing
the state of anything.  The merging needs to happen earlier.

> Another option could be to change all the calls that set the error
> message to *append* to the error message instead. Thoughts on that?

That might work ... but we'd probably have to add some "clear the
message" calls in places.  It might be worth trying to restrict this
convention to the connection-startup code.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: Buffer pool statistics in Explain Analyze
Next
From: Gregory Stark
Date:
Subject: Re: recursive query crash