Re: float8 regression failure (HEAD, cygwin) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: float8 regression failure (HEAD, cygwin)
Date
Msg-id 1080.1154435666@sss.pgh.pa.us
Whole thread Raw
In response to Re: float8 regression failure (HEAD, cygwin)  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: float8 regression failure (HEAD, cygwin)  ("Adrian Maier" <adrian.maier@gmail.com>)
Re: float8 regression failure (HEAD, cygwin)  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Maybe we need to abandon trying to map float8 results exactly in the
> resultmap file, and just let pg_regress pick the best fit as we do with
> some other tests.

I thought about that too but it seems a very bad idea.  small-is-zero is
distinctly "less correct" than the regular output, and I don't think we
want pg_regress to be blindly accepting it as OK on any platform.

Perhaps we could stick a version check into the resultmap lookup?  It'd
likely have been painful on the shell script implementation but now that
the code is in C I think we have lots of flexibility.  There's no need
to feel bound by the historical resultmap format.

However this is all premature unless we can verify that "cgywin's strtod()
complains about float underflow after version so-and-so".  Do they
publish a detailed change log?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Online index builds
Next
From: Bruce Momjian
Date:
Subject: Re: Online index builds