Re: remove bits* types - Mailing list pgsql-hackers

From Tom Lane
Subject Re: remove bits* types
Date
Msg-id 1074366.1773873680@sss.pgh.pa.us
Whole thread Raw
In response to Re: remove bits* types  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: remove bits* types
List pgsql-hackers
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> Shrug.  As I said in the other thread, it seems mildly useful to
> distinguish the cases where stuff is there solely to be treated as a
> mask of independent bits instead of something you do arithmetic with.

I could get behind that if we were declaring bitmask variables using
bitsNN more or less consistently, but if we do that at all it's a
minority usage.  I didn't even realize there was any such convention.
A lot of the places Nathan is changing don't look like they are
following such a convention anyway.

In short: maybe we don't want to go in the direction Nathan suggests,
but if we keep these types we should make an effort to use them
more consistently, so there's work to be done in that direction too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: EXPLAIN: showing ReadStream / prefetch stats
Next
From: Tom Lane
Date:
Subject: Re: pg_plan_advice