Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I think we are at a point that people running on systems with no int64
> support should not expect to get valid return values for >2 billion row
> COPY operations.
I agree, there's no need to work harder on this than changing the
datatype to uint64.
There are some places (vacuum and index build IIRC) that use "double"
counters instead of either int32 or int64. That was a good compromise
a few years ago, but I'm not sure we still need it. I think we can
reasonably say that our goals for backward-compatibility to systems
with no int64 datatype do not include working nicely with tables
exceeding 4G rows.
I didn't like that the patch introduced new buffer variables that were
not there before --- that is just adding complexity to no point. This
patch should not need to do more than change some variables' datatypes
and adjust printf formats and string buffer lengths to match.
regards, tom lane
