Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?)
Date
Msg-id 10683.1412021990@sss.pgh.pa.us
Whole thread Raw
In response to Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Sep 29, 2014 at 3:37 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> Ah. DetermineSleepTime(), which is called while signals are unblocked!,
>> modifies BackgroundWorkerList. Previously that only iterated the list,
>> without modifying it. That's already of quite debatable safety, but
>> modifying it without having blocked signals is most definitely
>> broken. The modification was introduced by 7f7485a0c...

> Ouch.  OK, yeah, that's a bug.

Yeah.  Can we just postpone the signal unblock till after that function?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: open items for 9.4
Next
From: Andres Freund
Date:
Subject: Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?)