On 08/10/2026 12:04, Chee Wooson wrote:
> Hi,
>
> Since v3 no longer applied cleanly due to conflicts, I rebased it onto current master at 061065e28f0. Attached is
v4.
Thanks, the fix looks correct to me.
I spend some time rewriting all the comments; I found them pretty
difficult to read. Notable, they used many words to explain that a
transaction might not be marked as committed or aborted but we have
already checked that it is not running hence it cannot commit in the
future. While that's all true, I think it's still OK, and more
understandable to a human, to just call it an "aborted transaction", or
"aborted (or crashed) transaction" if you want to call out crashed
transactions separately. That's a concept that's explained in more
detail in existing comments in heapam_visibility.c.
See attached version with my comment changes.
- Heikki
