Re: mcxt.c - Mailing list pgsql-patches

From Neil Conway
Subject Re: mcxt.c
Date
Msg-id 1063045953.9051.48.camel@tokyo
Whole thread Raw
In response to Re: mcxt.c  ("Gaetano Mendola" <mendola@bigfoot.com>)
List pgsql-patches
On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> > I see no value at all in an assert.  The code will dump core just fine
> > with or without an assert ...
>
> Right but an assert can display information about the file and line number
> without debug the application

I think the percentage of deployments that enable assertions (which
causes a runtime performance hit) but NOT debugging info (which does
not) is pretty small.

ISTM that checking for non-NULL pointers is pretty pointless: just
because a pointer happens to be non-NULL doesn't mean it is any more
valid, and dereferencing a NULL pointer is easy enough to track down in
any case.

-Neil



pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Minor lmgr code cleanup
Next
From: "Ron Mayer"
Date:
Subject: Re: ISO 8601 "Time Intervals" of the "format with time-unit deignators"