Request a Demo
Home   >   mailing lists

Re: Cleanup shadows variable warnings, round 1 - Mailing list pgsql-hackers

From Chao Li
Subject Re: Cleanup shadows variable warnings, round 1
Date
Msg-id 105E05F5-4BF1-459F-8012-94D90C75BE0F@gmail.com
Whole thread Raw
In response to Re: Cleanup shadows variable warnings, round 1  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
Tree view 

> On Dec 4, 2025, at 05:00, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Thu, Dec 4, 2025 at 1:36 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>>
>> On 2025-Dec-03, Chao Li wrote:
>>
>>> Unfortunately that doesn’t work for my compiler (clang on MacOS),
>>> that’s why I renamed “I" to “u”.
>>
>> I think you're missing his point.  He's suggesting to change not only
>> this variable, but also the other uses of "i" in this function.
>>
>
> Exactly. I should have posted the larger diff, as you did. Thanks for
> clarifying.
>

Sorry for misunderstanding you. I guess I read your message too quickly yesterday. Will fix it in v4.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [PATCH] Add error hints for invalid COPY options
Next
From: Melanie Plageman
Date:
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)