Re: implement query_start for pg_stat_activity - Mailing list pgsql-patches

From Neil Conway
Subject Re: implement query_start for pg_stat_activity
Date
Msg-id 1045687500.585.413.camel@tokyo
Whole thread Raw
In response to implement query_start for pg_stat_activity  (Neil Conway <neilc@samurai.com>)
Responses Re: implement query_start for pg_stat_activity  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: implement query_start for pg_stat_activity  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: implement query_start for pg_stat_activity  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: implement query_start for pg_stat_activity  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
On Wed, 2003-02-19 at 00:27, Neil Conway wrote:
> This patch implements the TODO item
>
>     - Add start time to pg_stat_activity

I've attached a revised version of the patch with the following changes:

- use longer function names, as suggested by Tom

- (unrelated) replace some instances where snprintf() was called with a
constant buffer size with sizeof

- documentation improvements

- update regression tests

- change the method of finding the current date & time -- it's still an
ugly hack, although arguably less so. Now we do:

AbsoluteTime sec;
int usec;

sec = GetCurrentAbsoluteTimeUsec(&usec);

/* when displaying the time */
Timestamp result;

#ifdef HAVE_INT64_TIMESTAMP
result = (((sec - ((date2j(2000, 1, 1) - date2j(1970, 1, 1)) * 86400))
           * INT64CONST(1000000)) + usec);
#else
result = (sec + (usec * 1.0e-6) - ((date2j(2000, 1, 1) -
                date2j(1970, 1, 1)) * 86400));
#endif

which is the same method now() uses internally.

Cheers,

Neil
--
Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC



Attachment

pgsql-patches by date:

Previous
From: "Jeroen Habets"
Date:
Subject: Patch AbstractJdbc1Statement.setBoolean support BIT and INTEGER columns
Next
From: Bruce Momjian
Date:
Subject: Re: pg_avd