Re: BUG #6672: Memory leaks in dumputils.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #6672: Memory leaks in dumputils.c
Date
Msg-id 10452.1338738869@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #6672: Memory leaks in dumputils.c  (Josh Kupershmidt <schmiddy@gmail.com>)
List pgsql-bugs
Josh Kupershmidt <schmiddy@gmail.com> writes:
>> zaks.anna@gmail.com writes:
>>> There are two memory leaks in dumputils (v9.2.0beta1):

> ... Both of these errors seem academic, since the callers
> of buildACLCommands() will bail out with exit_horribly() or
> exit_nicely() if it returns false. But IMO it's worth fixing anyway,
> to keep the compilers happy or in case of future code calling
> buildACLCommands() or parseAclItem().

Agreed.

> Attached is a patch to hopefully fix those two errors.

Applied, thanks.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #6673: Value out of range for type integer when adding WHERE clause
Next
From: Shigeru Hanada
Date:
Subject: control character check in JSON type seems broken