Re: Cosmetic change in catalog/index.c - Mailing list pgsql-patches

From Neil Conway
Subject Re: Cosmetic change in catalog/index.c
Date
Msg-id 1045177045.8746.3.camel@tokyo
Whole thread Raw
In response to Cosmetic change in catalog/index.c  ("Greg Sabino Mullane" <greg@turnstep.com>)
Responses Re: Cosmetic change in catalog/index.c
List pgsql-patches
On Thu, 2003-02-13 at 10:09, Greg Sabino Mullane wrote:
> Very minor cosmetic patch to catalog/index.c: I noticed when replying to
> bug #895 that the error message "relation already exists" is not
> capitilized as the rest are:

On the contrary, I can't see any kind of consistency in the leading
capitalization in elog() messages. If you're only going to make a few
arbitrary changes but not make things consistent, it doesn't seem to be
worth the risk of breaking client apps that examine error message
strings.

> This patch fixes that and a few other places where the capitilization
> is needed.

Shouldn't you update translations as well?

Cheers,

Neil
--
Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC




pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] parse_expr.c another type produced by transformations?
Next
From: Tom Lane
Date:
Subject: Re: trivial patch for pg_dump blob problem