Re: [BUGS] postmaster segfaults when pg_hba.cof is missing - Mailing list pgsql-patches

From Neil Conway
Subject Re: [BUGS] postmaster segfaults when pg_hba.cof is missing
Date
Msg-id 1039733662.354.32.camel@tokyo
Whole thread Raw
Responses Re: [BUGS] postmaster segfaults when pg_hba.cof is missing  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: [BUGS] postmaster segfaults when pg_hba.cof is missing  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
On Thu, 2002-12-12 at 13:13, Rudy Lippan wrote:
> I know this is a broken install, but postmaster should not segfault when
> it can't find a file.
>
> postgres@war PGDATA $ ../pgsql7.3/bin/postmaster
> LOG:  load_hba: Unable to open authentication config file
> "/usr/local/PGDATA/pgsql7.3/pg_hba.conf": No such file or directory
> Segmentation fault (core dumped)

Good catch. Here's a patch against CVS HEAD that fixes the problem.

The actual segfault was caused by a double pfree(), but ISTM that
failing to find pg_hba.conf should be a fatal error anyway, so I
increased the priority of the elog() from LOG to FATAL and refactored
the code a little bit.

Bruce: unless anyone has an objection, please apply.

Thanks for the report.

Cheers,

Neil

Attachment

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PyGreSQL, suggestion for DB wrapper class
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql ALTER command tab completion