Re: database file compatibility patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: database file compatibility patch
Date
Msg-id 10395.1128305499@sss.pgh.pa.us
Whole thread Raw
In response to Re: database file compatibility patch  (Qingqing Zhou <zhouqq@cs.toronto.edu>)
List pgsql-patches
Qingqing Zhou <zhouqq@cs.toronto.edu> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> wrote
>> There's not much need to check endianness explicitly, since the
>> pg_control_version check will surely fail if there's an endianness
>> discrepancy (not to mention the other checks on pg_control fields).

> Oh, right. So for the same reason, is it safe to remove the endian check
> in FsmCacheFileHeader?

[ Scratches head... ]  Yeah, I would think so.  I'm trying to remember
why I put that code in there in the first place ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Qingqing Zhou
Date:
Subject: Re: database file compatibility patch
Next
From: Qingqing Zhou
Date:
Subject: cleanup log_disconnections()